thephpleague / csv

CSV data manipulation made easy in PHP
https://csv.thephpleague.com
MIT License
3.34k stars 336 forks source link

Any Idea why I am getting this error? Please help #494

Closed w3guy closed 1 year ago

w3guy commented 1 year ago

Bug Report

(Fill in the relevant information below to help triage your issue.)

Information Description
Version 9.6.2
PHP version 7.2.5
OS Platform

The error is thrown by the WordPress plugin repository linter.

image

w3guy commented 1 year ago

Cc @nyamsprod

nyamsprod commented 1 year ago

@w3guy I am not familiar with this package but the error message says it all the filtername parameter get something which is not a string. Why and how I'm afraid that I can't help you with. It depends how the class is being called and use

w3guy commented 1 year ago

Apparently the linter throwed that error because $filtername and $param concrete implementation in the charset class didn't exactly comply with their definitions in php_user_filter.

Removing them fixed the issue.

I also discovered they are not in their respective latest version files. You probably removed them as their presence were redundant since you basically were redeclaring them.

image

nyamsprod commented 1 year ago

indeed they got removed in 9.7.2 according to the tags