Enhancement: Require fzaninotto/faker:^1.5

thephpleague / factory-muffin

Enables the rapid creation of objects for testing

https://factory-muffin.thephpleague.com/

MIT License

531 stars 72 forks source link

Closed localheinz closed 8 years ago

localheinz commented 8 years ago

This PR

[x] requires fzaninotto/faker:^1.5 so we can use it in projects already requiring the latest versions of fzaninotto/faker
[x] fixes the test by asserting that the image url starts with the expected url

localheinz commented 8 years ago

@GrahamCampbell

Would be cool if you could take a look soon at #400 and this (happy to rebase once #400 has been merged).

Ideally, also tag soon?

GrahamCampbell commented 8 years ago

Faker 1.5 is available in Factory Muffin 3. We can't upgrade 2.x because it's a BC break.

GrahamCampbell commented 8 years ago

BC break as proven by the fact our tests broke and you had to change them.

localheinz commented 8 years ago

So when is 3.0 going to be released?

GrahamCampbell commented 8 years ago

3.0 is already "stable". I just don't want to tag v3.0.0 until the docs are up to standard.