Closed DavertMik closed 8 years ago
Thanks. I've left a few comments.
Could you skip the failing tests on hhvm too please?
Done.
updtd
done
Ping-ping?
Done. But I hope that was the last part of codestyling and dockblock bureaucracy )
Thanks for all your work here. I appreciate it very much. I'll do a final review of this at the weekend and then merge. :)
Ok, will be waiting for that and for final release of 3.0 :+1:
@GrahamCampbell yep, about 3.0. With this PR I have plans to include factory-muffin in Codeception 2.2 but I need to know your release plans so to decide If I can stick to it. It's not a nice idea to rely on beta dependency (
Thank you @DavertMik.
@DavertMik v3.0.0 is released now, even with incomplete upgrading docs. That was the main reason I was holding off, but it'a already like 18 months late, so I'm just going to ship it.
Factory Muffin 3.x will be maintained into the future, and follows semver.
Awesome!
Now you can use have FactoryMuffin to work with DataMapper pattern, especially with Doctrine. To have FactoryMuffin to be initialized with Doctine you should use
RepositoryStore
instead ofModelStore
class:Unlike model store you can't use
factory
prefix to create associated models.factory
creation method is supported to create a record and recturn its id, while Doctrine expects to receive a complete entity into association. That's why you should useentity
to get a record into associationAlso Doctrine added as dev dependency and tests for it added.