search

thephpleague / factory-muffin

Enables the rapid creation of objects for testing
https://factory-muffin.thephpleague.com/
MIT License
532 stars 72 forks source link

Rename reference to upstream lib in README #450

Closed BPScott closed 4 years ago

BPScott commented 6 years ago

factory_girl has been renamed to factory_bot. Lets reference the new name.

GrahamCampbell commented 6 years ago

Thanks for the PR. I'm tempted not to, since it was modeled on the original package, with the old name.

BPScott commented 6 years ago

But the contents of the package remains exactly the same, with the exception that the name has changed. The name change has resulted in zero logic changes. So you're still based on the original packages.

Also what happens if Github ends up breaking their repository redirects? Leaving a link to https://github.com/thoughtbot/factory_girl would break. Even if you disagree with the name change, not pushing users through a 301 redirect would be useful.