Closed philsturgeon closed 10 years ago
You could just do it, can always just revert :) i think it looks awesome though.
Yeh, but we need the cname setting up.
I'll put it up onto gh-pages in a few mins.
:) thanks
Hmm, well for now, this works: http://thephpleague.com/factory-muffin/.
We just don't have a subdomain yet.
Hi gents, just back from holidays and following up on this. I'm personally not a fan of having different style documentation sites for different League packages. The idea was to create consistency between our projects, both from a branding perspective, but also so that dev's familiar with the League will know what to expect. I'd encourage you to get an actual League site up eventually, although there is clearly no major urgency to it.
That's fine. Also, Factory Muffin is missing from the package lists on the other league websites and the main site.
@GrahamCampbell I am happy with your one being the site for now though. I shall do the site when i get an hour or so to sit down and have a go.
That's fine. Also, Factory Muffin is missing from the package lists on the other league websites and the main site.
Simply add it to this file: https://github.com/thephpleague/thephpleague.github.com/blob/master/_data/packages.yml
Yeh, but we have 2 authors. How does that work?
We could get married and use Mr and Mr? That seems like a reasonable solution to me.
Lol. We have two different user names on github though.
Good point. Can you just put one for now? Will have to rethink how that works.
Better put Scott down. He's been here the longest. :)
@reinink you have to decide who you like the most :P
HAHA, that's not MY call! :)
Who originally started it?
@GrahamCampbell To be fair, neither of us started this originally. I mean, it's not the same code anymore at all, but still.
@Zizaco originally started it, so many we should put his name? Not sure how much he wants to be involved in this anymore though.
It's meant to show the project lead, not who originally created it. So either of you is fine at this point if you're both leading it.
@GrahamCampbell you decide.
Hmmm. It's not really Zizaco's project now though. Just put Scott down. He's been here longer than I have. We can add me once you work out how to do it. :)
Sounds good. Also, one of the goals with the League is to make it about the packages more than the people. The only reason we show a project lead is for the purpose of giving a contact—not for credit purposes. From our website:
WE’RE ALL ABOUT PACKAGES
This group is about packages, and not about the people. To keep that clear - and to make sure people are joining for the right reasons - no members list will be posted, but we’ll let you know who is in charge of packages so you can poke them with feedback.
Yeah i was going to say that, do we NEED an author? Can we not make it optional?
I think for consistency it would be nice to have. As in, I wouldn't remove it just because there are two project leads.
Can you just write something. It's not worth the discussion, as long as the package is added.
@GrahamCampbell I think we need to submit a PR
@scottrobertson Yep, if you need me to do it let me know.
@reinink That might be easier if you could.
On it.
Thank you @reinink
It seems to be working now: http://factory-muffin.thephpleague.com/. I've put the api docs on there too.
@scottrobertson If you don't have time, I can sort the sculpin website tomorrow.
I'm working on this now.
Thanks. Sorry i missed your comment last night.
Done: http://factory-muffin.thephpleague.com/. You may need to ctrl+f5
to see the new site or whatever.
Awesome, thank you @GrahamCampbell
@reinink Sculpin isn't rendering bullet points correctly: http://factory-muffin.thephpleague.com/usage/more/
@GrahamCampbell You just needed an extra line return. I've added this, but you still need to republish.
Ok. There are probably a few other occurrences I'll need to find. I'll republish the site later today. There are a few other things I need to fix.
Thanks @reinink
Happy to help gents. I've also added Google Analytics and fixed your permalinks.
Thanks. Also, how do we access the analytic data? Can it be read-only shared with our google accounts?
For sure, just provide me with your Google account email address.
I'll email them to you...
Mine is added :)
I've just regenerated the website now.
awesome, looks good :D
Who wants the job of making the documentation for the website?
Instructions here