thephpleague / factory-muffin

Enables the rapid creation of objects for testing
https://factory-muffin.thephpleague.com/
MIT License
533 stars 72 forks source link

Offical Website #67

Closed philsturgeon closed 10 years ago

philsturgeon commented 10 years ago

Who wants the job of making the documentation for the website?

Instructions here

scottrobertson commented 10 years ago

You could just do it, can always just revert :) i think it looks awesome though.

GrahamCampbell commented 10 years ago

Yeh, but we need the cname setting up.

GrahamCampbell commented 10 years ago

I'll put it up onto gh-pages in a few mins.

scottrobertson commented 10 years ago

:) thanks

GrahamCampbell commented 10 years ago

Hmm, well for now, this works: http://thephpleague.com/factory-muffin/.

We just don't have a subdomain yet.

reinink commented 10 years ago

Hi gents, just back from holidays and following up on this. I'm personally not a fan of having different style documentation sites for different League packages. The idea was to create consistency between our projects, both from a branding perspective, but also so that dev's familiar with the League will know what to expect. I'd encourage you to get an actual League site up eventually, although there is clearly no major urgency to it.

GrahamCampbell commented 10 years ago

That's fine. Also, Factory Muffin is missing from the package lists on the other league websites and the main site.

scottrobertson commented 10 years ago

@GrahamCampbell I am happy with your one being the site for now though. I shall do the site when i get an hour or so to sit down and have a go.

reinink commented 10 years ago

That's fine. Also, Factory Muffin is missing from the package lists on the other league websites and the main site.

Simply add it to this file: https://github.com/thephpleague/thephpleague.github.com/blob/master/_data/packages.yml

GrahamCampbell commented 10 years ago

Yeh, but we have 2 authors. How does that work?

scottrobertson commented 10 years ago

We could get married and use Mr and Mr? That seems like a reasonable solution to me.

GrahamCampbell commented 10 years ago

Lol. We have two different user names on github though.

reinink commented 10 years ago

Good point. Can you just put one for now? Will have to rethink how that works.

GrahamCampbell commented 10 years ago

Better put Scott down. He's been here the longest. :)

scottrobertson commented 10 years ago

@reinink you have to decide who you like the most :P

reinink commented 10 years ago

HAHA, that's not MY call! :)

Who originally started it?

scottrobertson commented 10 years ago

@GrahamCampbell To be fair, neither of us started this originally. I mean, it's not the same code anymore at all, but still.

scottrobertson commented 10 years ago

@Zizaco originally started it, so many we should put his name? Not sure how much he wants to be involved in this anymore though.

reinink commented 10 years ago

It's meant to show the project lead, not who originally created it. So either of you is fine at this point if you're both leading it.

scottrobertson commented 10 years ago

@GrahamCampbell you decide.

GrahamCampbell commented 10 years ago

Hmmm. It's not really Zizaco's project now though. Just put Scott down. He's been here longer than I have. We can add me once you work out how to do it. :)

reinink commented 10 years ago

Sounds good. Also, one of the goals with the League is to make it about the packages more than the people. The only reason we show a project lead is for the purpose of giving a contact—not for credit purposes. From our website:

WE’RE ALL ABOUT PACKAGES

This group is about packages, and not about the people. To keep that clear - and to make sure people are joining for the right reasons - no members list will be posted, but we’ll let you know who is in charge of packages so you can poke them with feedback.

scottrobertson commented 10 years ago

Yeah i was going to say that, do we NEED an author? Can we not make it optional?

reinink commented 10 years ago

I think for consistency it would be nice to have. As in, I wouldn't remove it just because there are two project leads.

GrahamCampbell commented 10 years ago

Can you just write something. It's not worth the discussion, as long as the package is added.

scottrobertson commented 10 years ago

@GrahamCampbell I think we need to submit a PR

reinink commented 10 years ago

@scottrobertson Yep, if you need me to do it let me know.

GrahamCampbell commented 10 years ago

@reinink That might be easier if you could.

reinink commented 10 years ago

On it.

scottrobertson commented 10 years ago

Thank you @reinink

GrahamCampbell commented 10 years ago

It seems to be working now: http://factory-muffin.thephpleague.com/. I've put the api docs on there too.

GrahamCampbell commented 10 years ago

@scottrobertson If you don't have time, I can sort the sculpin website tomorrow.

GrahamCampbell commented 10 years ago

I'm working on this now.

scottrobertson commented 10 years ago

Thanks. Sorry i missed your comment last night.

GrahamCampbell commented 10 years ago

Done: http://factory-muffin.thephpleague.com/. You may need to ctrl+f5 to see the new site or whatever.

scottrobertson commented 10 years ago

Awesome, thank you @GrahamCampbell

GrahamCampbell commented 10 years ago

@reinink Sculpin isn't rendering bullet points correctly: http://factory-muffin.thephpleague.com/usage/more/

reinink commented 10 years ago

@GrahamCampbell You just needed an extra line return. I've added this, but you still need to republish.

GrahamCampbell commented 10 years ago

Ok. There are probably a few other occurrences I'll need to find. I'll republish the site later today. There are a few other things I need to fix.

scottrobertson commented 10 years ago

Thanks @reinink

reinink commented 10 years ago

Happy to help gents. I've also added Google Analytics and fixed your permalinks.

GrahamCampbell commented 10 years ago

Thanks. Also, how do we access the analytic data? Can it be read-only shared with our google accounts?

reinink commented 10 years ago

For sure, just provide me with your Google account email address.

GrahamCampbell commented 10 years ago

I'll email them to you...

scottrobertson commented 10 years ago

Mine is added :)

GrahamCampbell commented 10 years ago

I've just regenerated the website now.

scottrobertson commented 10 years ago

awesome, looks good :D