search

thephpleague / flysystem-rackspace

Flysystem Adapter for Rackspace
37 stars 28 forks source link

Added the possibility to create directories #17

Closed rvmourik closed 8 years ago

frankdejonge commented 8 years ago

Travis didn't run yet, however I have the feeling it's not going to pass since the tests have not been corrected to account for this case.

rvmourik commented 8 years ago

Okay, i'm not very familiar with Travis and Unit testing (yet), so is this something that needs work from my end or yours?

frankdejonge commented 8 years ago

@rvmourik the test case needs to be updated which is located here: https://github.com/thephpleague/flysystem-rackspace/blob/master/tests/RackspaceAdapterTests.php#L158

rvmourik commented 8 years ago

@frankdejonge I removed the Contents None (our Cloud support department gave this as something that needed to be present, but just tested it, and it works without). I also changed the test to an assertTrue, but it still fails.

rvmourik commented 8 years ago

@frankdejonge can you tell me what needs to be done about the test in order to make it pass? Thanks.

frankdejonge commented 8 years ago

@rvmourik I've merged and corrected the PR. Thanks!

rvmourik commented 8 years ago

@frankdejonge thanks!