BUGFIX: write/update stream write nothing for unseekable resource.

thephpleague / flysystem-replicate-adapter

Flysystem Adapter Decorator for Replicating Filesystems.

24 stars 11 forks source link

BUGFIX: write/update stream write nothing for unseekable resource. #4

Closed Leechael closed 9 years ago

Leechael commented 9 years ago

Fixed original #2 problem report by myself.

This patch do not includes any test cases as some extra-packages required to installed before.

The solution is ugly but works, and will ate large memory when handling big files (so please consider another way to handling big files replication).

twistor commented 9 years ago

Hey, this is pretty good. Since this is using streams, there's no problems with memory usage. The only thing I'm wondering about is if we should copy the stream locally first, but I think this is a better fix, since the primary adapter should be a fast one.