search

thephpleague / flysystem-sftp

[READ-ONLY SUBSPLIT] Flysystem Adapter for SFTP
308 stars 95 forks source link

Refactor: split login process #104

Open rymiyamoto opened 4 years ago

rymiyamoto commented 4 years ago

I don't think it's good to use goto statements. For that reason, we reviewed the login process.

Please review.

frankdejonge commented 4 years ago

What was the problem with the goto statement? What concrete problem are you fixing with this PR?

rymiyamoto commented 4 years ago

Thank you for your reply.

I think that using goto statement is because the process of attempting to login is complicated. It's not bad to use a goto statement, but it's not common, so I just split the process and refactored.

Also, the use of goto statements is likely to be complicated in the future.