search

thephpleague / flysystem

Abstraction for local and remote filesystems
https://flysystem.thephpleague.com
MIT License
13.23k stars 825 forks source link

Rename ContentMD5 to AddContentMD5 for AWS #1767

Closed alexndlm closed 2 months ago

frankdejonge commented 2 months ago

@alexndlm any chance you can link to the relevant docs that highlight this change?

alexndlm commented 2 months ago

@frankdejonge , please see here https://github.com/aws/aws-sdk-php/blob/0a910d2b35e7087337cdf3569dc9b6ce232aafba/src/S3/S3Client.php#L1040

alexndlm commented 2 months ago

@frankdejonge, any chances to merge this?

mattbartel commented 2 months ago

I don't think this is the correct change for this feature. According to the aws-sdk-php code in MultpartUploader.php, ObjectUploader.php, and Transfer.php, it's the add_content_md5 option that should be added. I don't see any code in the SDK looks for the ContentMD5 or AddContentMD5 flags directly so I think they can just be removed. I submitted another pull request here: https://github.com/thephpleague/flysystem/pull/1774

alexndlm commented 2 months ago

@mattbartel thanks. c94490e273b3f979884bffadcacbe7b1

Closed in favor of https://github.com/thephpleague/flysystem/pull/1774