philsturgeon
commented
10 years ago I think talking about converting snake_case to camelCase might be confusing the issue a little, but we can have this discussion with a slightly more common use-case.
Somebody asked me if Fractal would be good for converting their JSON into a format for their models to save. For me this was not something I ever considered doing for Fractal as the entire point for me was just to convert disparate and potentially complex data sources into consistent output for easy formatting and output.
Let's try out some theory code. It would be possible for me to have an input / output approach, where output is the current transform method and input takes data in whatever format and converts it to an instance of whatever it is you are trying to make.
<?php namespace App\Transformer;
use League\Fractal\TransformerAbstract;
use Opp;
class OppTransformer extends TransformerAbstract
{
/**
* Available embeds
*
* @var array
*/
protected $availableEmbeds = [
'category',
'merchant',
];
/**
* Turn this item object into a generic array
*
* @param array $input
*
* @return Opp
*/
public function input(array $input)
{
$opp = new Opp([
'id' => (int) $input['id'],
'type' => (string) $input['type'],
'name' => (string) $input['name'],
'teaser' => (string) $input['teaser'],
'details' => (string) $input['details'],
'trending' => (bool) $input['trending'],
]);
$opp->ormMagicRelationship($input['category_id']);
$opp->ormMagicRelationship($input['merchant_id']);
}
/**
* Turn this item object into a generic array
*
* @return array
*/
public function output(Opp $opp)
{
return [
'id' => (int) $opp->id,
'type' => (string) $opp->type,
'name' => (string) $opp->name,
'teaser' => (string) $opp->teaser,
'details' => (string) $opp->details,
'trending' => (bool) $opp->trending,
];
}
/**
* Embed Category
*
* @param Opp $opp
*
* @return League\Fractal\Resource\Item
*/
public function embedCategory(Opp $opp)
{
return $this->item($opp->category, new CategoryTransformer);
}
/**
* Embed Merchant
*
* @param Opp $opp
*
* @return League\Fractal\Resource\Item
*/
public function embedMerchant(Opp $opp)
{
return $this->item($opp->merchant, new MerchantTransformer);
}
}Is that the sort of thing you want? The embed logic would need to stay as output only, and you could make other instances and whatnot. You could hide more of the logic in your models/repositories/other domain code, and just use this as a general wrapper for things, but I have to wonder if this is even the responsibility of Fractal.
If Fractal handles output, nesting/embedding of relationships, etc, shouldn't your input be handled in a model/repository somewhere? There is no complicated output, nesting, etc for saving some shit. It's just passing data to some methods.
alexbilbie
fideloper
rogierborst
awright022
I was wondering, isn't this a very one-way transformation? Let's say my repo is using snake_case and with fractal I'm outputting as camelCase.
Now the client wants to create a new instance and for all he knows, we're using camelCase throughout our api. So he'll post with camelCase definitions.
Does fractal then provide a way to transform back to snake_case?