search

thephpleague / glide

Wonderfully easy on-demand image manipulation library with an HTTP based API.
http://glide.thephpleague.com
MIT License
2.55k stars 198 forks source link

Add support for AVIF #333

Closed gijsdev closed 2 years ago

gijsdev commented 2 years ago

This PR adds support for the AVIF image format. Intervention/Image added support for AVIF for the Imagick driver in 2.6.0 (https://github.com/Intervention/image/pull/1056) and for the GD driver in 2.7.0 (https://github.com/Intervention/image/pull/1113).

gijsdev commented 2 years ago

If this PR gets accepted, should I create a separate PR for Glide 1.x? Or is Glide 1.x in maintenance only mode?

ADmad commented 2 years ago

Please rebase your branch on to upstream master. I updated the GA workflow to run the tests on PHP 8.1 since AVIF support is only available from PHP 8.1.

ADmad commented 2 years ago

Or is Glide 1.x in maintenance only mode?

It's in maintenance only mode.

gijsdev commented 2 years ago

Done 👌

ADmad commented 2 years ago

LGTM.

@tgalopin Do you have any feedback?