search

thephpleague / glide

Wonderfully easy on-demand image manipulation library with an HTTP based API.
http://glide.thephpleague.com
MIT License
2.55k stars 198 forks source link

Enable TIFF image format handling, fixes #344 #345

Closed Synchro closed 2 years ago

Synchro commented 2 years ago

Further to #344, here's a PR to enable TIFF image format support. I saw that there were some vestiges of TIFF format support already (for example the tif property in the test case), so I've made use of that. The test suite runs only with the gd driver, so operations that require imagick (which includes the TIFF format) can't be tested, so I wrote a new test method that reconfigures the test to run with imagick, and skips the test if it's not installed.

I don't understand how the mock works in testGetFormat – I tried copying it but couldn't make it work, so I've not created a similar test for that.

ADmad commented 2 years ago

Please add imagick to the extensions list here to ensure it's available https://github.com/thephpleague/glide/blob/3aa453969f28ae3b9f3a1fdcfca0147ee5454567/.github/workflows/test.yaml#L39

Synchro commented 2 years ago

I've added that.

Synchro commented 2 years ago

Thanks

ADmad commented 2 years ago

Thank you! New release done.