Open konnng-dev opened 4 months ago
TODO:
@ADmad would you mind to take a look and tell me what you think?
I'm not sure if introducing this new encoding strategy would be the best for this package.
feedbacks are welcome :)
Sorry I haven't had the time to look into this but could you please address the failing tests in the meantime.
@ADmad I addressed all the issues that Github Actions was issuing.
Before setting this ready for review, could you point me the best place where I could add the tests for the progressive/interlaced images I am introducing?
@ADmad I added some comments to help the review process.
Ideally, it would be good to add tests for the new option added to the image API. But I don't have idea what would be the best place to put it.
@ADmad I applied the suggested changes and also add a new doc entry for the new option. I'm just not sure how to preview documentation locally, but I guess it is following the same convention used before.
Also, do you have idea on how we could test this new feature? I just updated EncodeTest
to comply with the recent changes, but I didn't have idea on how test that.
@ADmad friendly ping to check if you had time to review changes.
The intent of this PR is to introduce support to generate progressive JPEGs or interlaced images.
Couple days ago, the author of Intervention provided support to accomplish that https://github.com/Intervention/image/releases/tag/3.6.0
With that, I did some adjustments on Glide API to get the desired support.
Highlights:
Encode
manipulator moved from the$manipulators
list, because it needs to be the last manipulator to run when generating the images.Encode
manipulator now returns aEncodedImage
. This change avoids to double encode image when generating it.Encode
also makes more use of Interventionenums
to encode the image properly.