Functionality to establish a list of allowed tags to keep its attributes

IsraelSanabriaMx commented 8 years ago

Changes

Refactor HtmlConverterTest adding a dataProvider into unit testing.
Added white_tags property to establish an Array of allowed white tags.
Added white_tag_wildcard to mark only the allowed tags.
Added documentation of how to use this new functionality.

Default Values

white_tags => array(), //Empty array
white_tag_wildcard=> '|', //Pipe character

MrPetovan commented 6 years ago

Why did you remove so many test cases?

colinodell commented 6 years ago

Thank you for contributing this feature idea, and my sincerest apologies for taking so long to review it.

I like the idea of using configuration options to allow certain HTML tags and attributes to be preserved, but I'm not 100% convinced this is the best approach.

IMHO, I think we should provide two different options with similar semantics - let's call them whitelist (replacing what you suggested) and blacklist (replacing remove_nodes and possibly strip_tags) for now. Both would take an array of tag and attribute selectors like this:

array('address', 'a[href]', '[src]', 'meta[charset=utf-8]')

This would match:

All <address> elements
All links (<a>) containing an href property (thus excluding things like anchors)
Any tag containing a src attribute
<meta charset="utf-8"> (not convinced we need it to be this complex)

I think this approach would give much better control as it would also allow us to match/keep/discard certain attributes only on certain elements, but of course it would also be more complex to implement.

So while I do appreciate the work you've put into this, I would prefer to see something a little more unified and powerful. Thank you though!

thephpleague / html-to-markdown

Functionality to establish a list of allowed tags to keep its attributes #100