search

thephpleague / html-to-markdown

Convert HTML to Markdown with PHP
MIT License
1.77k stars 205 forks source link

Quoted literals become quotes and mess with links #186

Closed laacz closed 4 years ago

laacz commented 4 years ago

As per commonmark spec regarding quoting, " inside an attribute should become an escaped double quote \".

Reproduce with:

<a href="https://example.org/" title="This is &quot;title&quot;">Link</a>

Which becomes

"[Link](https://example.org/ "This is "title"")"

This is incorrect.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.