search

thephpleague / oauth1-client

OAuth 1 Client
MIT License
968 stars 73 forks source link

[1.x] Fixing the autoload and cleaning the tests #114

Closed arcanedev-maroc closed 4 years ago

arcanedev-maroc commented 4 years ago

1- Fixing the autoload warnings:

Deprecation Notice: Class League\OAuth1\Client\Tests\ServerStub located in oauth1-client/tests/stubs/ServerStub.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar://composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201
Deprecation Notice: Class League\OAuth1\Client\Tests\TrelloTest located in oauth1-client/tests/TrelloServerTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar://composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201
Deprecation Notice: Class League\OAuth1\Client\Tests\XingTest located in oauth1-client/tests/XingServerTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar://composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201

2- Moving the tests to autoload-dev instead of autoload in composer.json 3- fixing/cleaning the tests and misc files 4- Adding newlines at EOF

arcanedev-maroc commented 4 years ago

Hi @bencorlett, can you review this PR?

I'm also planing to add .gitattribute export-ignore

bencorlett commented 4 years ago

This PR is looking pretty good :) I've just left a bit of feedback if you could address this, that would be great.

arcanedev-maroc commented 4 years ago

Hi @bencorlett, i've made the last changes. Can you review it again ?

bencorlett commented 4 years ago

If you want, feel free to split your original autoloading PR into a smaller, standalone PR. It’s more likely to get accepted quicker if it doesn’t grow out of scope into something much larger. 3 smaller PRs are generally easier to digest than one larger one.

Thanks as always :)

arcanedev-maroc commented 4 years ago

Go ahead, the main issue is composer's warnings when you install the package:

Deprecation Notice: Class League\OAuth1\Client\Tests\ServerStub located in oauth1-client/tests/stubs/ServerStub.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar://composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201
Deprecation Notice: Class League\OAuth1\Client\Tests\TrelloTest located in oauth1-client/tests/TrelloServerTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar://composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201
Deprecation Notice: Class League\OAuth1\Client\Tests\XingTest located in oauth1-client/tests/XingServerTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar://composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201
bencorlett commented 4 years ago

@arcanedev-maroc okay, cool. So if you want to open up 2 PRs - one for the autoload, we’ll merge that in ASAP.

Then a second one with these improvements, we can keep the discussion going in that 🙂