search

thephpleague / oauth1-client

OAuth 1 Client
MIT License
968 stars 73 forks source link

Options for authorization URL #130

Closed patrickkusebauch closed 3 years ago

patrickkusebauch commented 3 years ago

In the same vein as the OAuth2 client the OAuth1 client should allow for additional options when constructing the Authorization Url. As per OAuth 1 RFC 5849:

Servers MAY specify additional parameters.

A second parameter for $options that would merge with the token from temp credentials would be ideal IMHO.

bencorlett commented 3 years ago

This functionality exists within V2 which I’m working through documenting in my spare time :)

I’m not planning on adding any new functionality to the existing version except security patches at this stage :)

Sent from my iPhone

On 13 Dec 2020, at 7:59 am, Patrick Kusebauch notifications@github.com wrote:

 In the same vein as the OAuth2 client the OAuth1 client should allow for additional options when constructing the Authorization Url. As per OAuth 1 RFC 5849:

Servers MAY specify additional parameters.

A second parameter for $options that would merge with the token from temp credentials would be ideal IMHO.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

patrickkusebauch commented 3 years ago

@bencorlett The latest released stable version is v1.8.2, and in that version, it is not present. Hence from a consumer's standpoint, it does not exist. What is necessary for v2 to be released?

bencorlett commented 3 years ago

Once I have finished up documenting V2, it’ll be released :) see the gh-pages branch.

Just finding the spare time to invest in this.

I welcome a PR if you want to add this to v1.

Sent from my iPhone

On 13 Dec 2020, at 10:05 am, Patrick Kusebauch notifications@github.com wrote:

 @bencorlett The latest released stable version is v1.8.2, and in that version, it is not present. Hence from a consumer's standpoint, it does not exist. What is necessary for v2 to be released?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.