search

thephpleague / oauth1-client

OAuth 1 Client
MIT License
968 stars 73 forks source link

Avoid "functions" from dependencies #134

Closed marcorocca closed 3 years ago

marcorocca commented 3 years ago

Guzzle has deprecated the use of functions provided by their dependencies (as you can see here) in their latest versions. I think it might make sense to upgrade the use of them in oauth1-client too, for example in EncodesUrl.php:

protected function createUrl($uri)
{
    return Psr7\uri_for($uri);
}

Becomes:

protected function createUrl($uri)
{
    return Psr7\Utils::uriFor($uri);
}

This will make the library future proof of any deprecation (and eventually give us the ability to use Mozart on it, as at the moment it will crash on those function calls).

smares commented 3 years ago

The library is now broken with the release of guzzlehttp/psr7 2.0 which itself is a dependency of guzzlehttp/guzzle 1.7.

bencorlett commented 3 years ago

I will prioritise fixing this. I might as well release 2.0 as well, I’ve been using it for months now :)

bencorlett commented 3 years ago

I have created #135 to address this. @smares did you want to cast your eye over this?