thephpleague / oauth1-client

OAuth 1 Client
MIT License
968 stars 73 forks source link

Trello "An unknown application" #137

Open alegag opened 3 years ago

alegag commented 3 years ago

Calling the class with parameter name don't seems to apply it to Trello.

$Trello = new Trello([
            'identifier' => c('TRELLO_KEY'),
            'secret' => c('TRELLO_SECRET'),
            'callback_uri' => Http::url(),
            'name' => c('APP_NAME'),
            'expiration' => 'never',
            'scope' => 'read,write'
        ]);

The value of APP_NAME get passed in the URL, but the result on the Trello auth-page is "An unknown application" instead of the expected value.

alegag commented 3 years ago

Turns out the length should be at least 5-chars (not documented on Trello side either, discovered by trial-and-error).

Should the Trello class throw an exception if name length is <=4 chars ? What do you think ? (I can do an MR for it if the proposition makes sense)

bencorlett commented 3 years ago

I'm not sure if this should be this package's responsibility to validate that, especially if it's not documented. However, if you would like to consider it, please

Also please note that Trello is not included as an out of the box provider in V2, however integrating custom providers is easy there.

Thanks!