search

thephpleague / oauth1-client

OAuth 1 Client
MIT License
968 stars 73 forks source link

Bitbucket OAuth #3

Closed cossou closed 10 years ago

bencorlett commented 10 years ago

Looks good!

cossou commented 10 years ago

Is it ok now @bencorlett & @philsturgeon?

bencorlett commented 10 years ago

Just left a comment, I'm sure there must a unique ID for a user. If you can fix that, looking great.

Tests failing are my fault. I will fix that up.

cossou commented 10 years ago

Hi @bencorlett, there is no unique ID in Bitbucket API. The only unique thing is the username.

bencorlett commented 10 years ago

Return that then :). We need a unique identifier of some sort. Many providers use strings :)

Sent from my iPad Please excuse my brevity

On 3 Dec 2013, at 7:43 pm, Hélder Duarte notifications@github.com wrote:

Hi @bencorlett, there is no unique ID in Bitbucket API. The only unique thing is the username.

— Reply to this email directly or view it on GitHub.

cossou commented 10 years ago

MERGE IT NOW! ;) Thanks @bencorlett!