search

thephpleague / oauth1-client

OAuth 1 Client
MIT License
968 stars 73 forks source link

Version 2.0 #35

Closed bencorlett closed 4 years ago

bencorlett commented 9 years ago

Version 2

bencorlett commented 9 years ago

This PR replaces #34.

ajibarra commented 9 years ago

Hi @bencorlett. Are you planning to merge this changes soon to develop or master? I am looking for the standard between both oauth1 and oauth2 client. Great work btw.

bencorlett commented 9 years ago

@ajibarra soon(ish), still working through the rewrite for v2 in my spare time. No real ETA as yet unfortunately. v1 is stable, just has an API that doesn't match the OAuth 2 client (it used to, but OAuth 2 has since moved forward and I'm catching up here).

stevenmaguire commented 8 years ago

@bencorlett you're making things happen! I'm happy to help out here and I don't want to impede your existing flow. If you can provide a deeper layer of detail about your current plan/thought process for the refactor, I can take care of some of the work.

stevenmaguire commented 8 years ago

40 encapsulates a bit of refactoring that I've been wanting to do. I've moved a handful of methods that are factories or static in nature to appropriate classes and created new classes where appropriate. My goal was to clean up the AbstractServer so it only had business critical logic.

stevenmaguire commented 8 years ago

Send arbitrary requests

This will be possible with the getAuthenticatedRequest method.

// The server provides a way to get an authenticated API request for
// the service, using the access token; it returns an object conforming
// to Psr\Http\Message\RequestInterface.
$request = $server->getAuthenticatedRequest(
    'GET',
    'http://your.service/endpoint',
    $tokenCredentials
);

$response = $this->getHttpClient()->send($request);
stevenmaguire commented 8 years ago

@bencorlett I see you are circling this project again. What are your thoughts on moving along this refactor? What is left to accomplish?

bencorlett commented 8 years ago

Good question!

Let me pull the code down today and have a look, I really need to stop being such a slacker haha.

I’ll do that today :)

On 23 Mar 2016, at 9:28 AM, Steven Maguire notifications@github.com wrote:

@bencorlett https://github.com/bencorlett I see you are circling this project again. What are your thoughts on moving along this refactor? What is left to accomplish?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/thephpleague/oauth1-client/pull/35#issuecomment-200061675

shehi commented 8 years ago

Any ETA on v2 folks?

GrahamCampbell commented 8 years ago

Any movement here?

mikemand commented 8 years ago

Any idea when this will be finished? Guzzle 4 is also EOL now, and v1 is still requiring Guzzle 3.

bencorlett commented 8 years ago

I'm back actively spending time on this project and I'm hoping to have the final refactoring done from the feature/switch-to-phpspec branch merged in within the week to release a beta of v2.

Following that, we just need to add implementations for more OAuth2 Servers and then we are good tor release.

elazar commented 8 years ago

@bencorlett Not to put too much more pressure on you, but a patch for a security vulnerability was included in Guzzle 6.2.1. I'm assuming the vulnerability exists in all prior versions and that those versions won't receive patches. So, the sooner the switch to Guzzle 6 can happen, the better. 😄

bencorlett commented 8 years ago

Ooo, interesting. Could you please provide me with a link? I might see if I can also patch 1.x to run on a newer Guzzle as well without needing a major bump. Pretty sure we won't be modifying any public methods so it could be a patch version.

Sent from my iPhone

Please excuse my brevity

On 23 Mar. 2016, at 9:55 am, Ben Corlett bencorlett@me.com wrote:

Good question!

Let me pull the code down today and have a look, I really need to stop being such a slacker haha.

I’ll do that today :)

On 23 Mar 2016, at 9:28 AM, Steven Maguire notifications@github.com wrote:

@bencorlett I see you are circling this project again. What are your thoughts on moving along this refactor? What is left to accomplish?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

elazar commented 8 years ago

@bencorlett Here's the site for the vulnerability: https://httpoxy.org/. The Guzzle release notes I linked in my earlier comment include a related item.

bencorlett commented 8 years ago

Oh, shit. Sorry I didn't see your link prior.

Okay, cool. I have a project for this morning ;)

Sent from my iPhone

Please excuse my brevity

On 19 Jul. 2016, at 8:45 am, Matthew Turland notifications@github.com wrote:

@bencorlett Here's the site for the vulnerability: httpoxy.org. The Guzzle release notes I linked in my earlier comment include a related item.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

stevenmaguire commented 8 years ago

@bencorlett I am still interested in helping to get this project moved up and out to 2.0. It seems like the current test suite configuration is causing some issues with CI. I've added some comments and would like some input and/or direction from you on how we should proceed.

I am happy to get some more work done here :)

stevenmaguire commented 7 years ago

Yoo-hoo @bencorlett

prisis commented 6 years ago

Do you need some help or is this project dead?

bencorlett commented 6 years ago

Progress on the project has kind of screamed to a halt. I did speak with @philsturgeon about having @stevenmaguire or somebody else equally keen to take over the lead. I would be more than happy for this, just unsure what his movements are and whether he is interested :)

On 5 Apr 2018, at 9:17 pm, Daniel Bannert notifications@github.com wrote:

Do you need some help or is this project dead?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thephpleague/oauth1-client/pull/35#issuecomment-378902186, or mute the thread https://github.com/notifications/unsubscribe-auth/AALGnyYUclxdV-plGuUXZqU_CXapsrF1ks5tlf08gaJpZM4FwWtN.

philsturgeon commented 6 years ago

We had this conversation over a year ago @bencorlett so yeah I'd say the swap should happen! 😅

I'm not involved in the League anymore, so pester @frankdejonge or somebody to get this a new home.

stevenmaguire commented 6 years ago

I'm happy to take on more responsibility with this project. I'll need to get back up to speed a bit. I've been very involved in this last round of changes but it's been quite some time since my head has been in this space :)

shehi commented 4 years ago

Any update here? :) We have Guzzle 7 now with PHP 7.2+ support.

shehi commented 4 years ago

Another question of mine is: who uses OAUTH-1 nowadays?! Haven't whole world moved to OAUTH-2 already?

GrahamCampbell commented 4 years ago

Twitter still uses oauth 1 only.

shehi commented 4 years ago

@GrahamCampbell , are you sure? https://developer.twitter.com/en/docs/authentication/oauth-2-0

shehi commented 4 years ago

@GrahamCampbell , sorry my bad. That link is not OAuth-2-on-behalf-of-user. It's just JWT-Bearer authentication (client-credential flow), on behalf of App.

mfn commented 4 years ago

Indeed, all the "real stuff" is still OAuth 1.0a => https://developer.twitter.com/en/docs/authentication/oauth-1-0a (basically the most important stuff for serious Twitter interaction)

shehi commented 4 years ago

Yea. I know for sure almost noone will bother updating this package. Tech is too old to be of any value to anyone.

Maybe for the sake of moving forward, at Socialite side there should be new major version release with Oauth-1 and Twitter left behind. Otherwise everything will be stuck in past.

shehi commented 4 years ago

Can someone add me as a Member to this repo?

CC: @bencorlett

shehi commented 4 years ago

I need that to be able to stop Travis-CI runs which I know will fail. Waiting for them takes too long.

shehi commented 4 years ago

After spending 7-8 hours to refactor this codebase, I can say the following:

Overall, even though there is Version-2 branch half-done, I'd strongly suggest actually redoing that work on top of my refactoring, also adding declare() s to files.

philsturgeon commented 4 years ago

@shehi this codebase started life as codeigniter-oauth1, which was built to work with PHP 4 as well as PHP 5. As such, some functions which existed in PHP 5 had to be reimplimented for the same of PHP 4 support. It's possible you're noticing some of this legacy, as of course you might notice with the types. Please boyscout respectfully and help chip away at any type mismatches, as again this was not built when types existed.

philsturgeon commented 4 years ago

@shehi also maybe you could start your own PR, as this was started by somebody who is no longer active on the project.

shehi commented 4 years ago

@philsturgeon really? CodeIgnitor and PHP4? Didn't know that. Older than I imagined!

Already started & finished my PR. I was just giving input regarding this PR, because a lot of work was done here without addressing the points I mentioned above. IMHO these shortcomings and problems should be addressed before building new features, or at least in parallel. My observation was: they weren't.