thephpleague / oauth1-client

OAuth 1 Client
MIT License
968 stars 73 forks source link

[2.0] Update setHttpClient signature to hint client interface #47

Closed stevenmaguire closed 8 years ago

bencorlett commented 8 years ago

On a side note, I'm almost deterred by suffixing Interface - I'd rather have the interface readable and implementations describe exactly what their concrete implementation does different... Thoughts?

stevenmaguire commented 8 years ago

Yeah, I'm usually in favor of that approach as well. This case was a bit different as the class still needs to know about the concrete implementation and the interface, both of which are provided by the guzzle project.

Perhaps we use HttpClient for the interface and something like GuzzleClient for the implementation references? I am deterred by Client begin reserved for third-party packages :)