thephpleague / oauth1-client

OAuth 1 Client
MIT License
968 stars 73 forks source link

Allow mult-dimension arrays when generating base string for HMAC-SHA1 signature. Fixes #39 #60

Closed jtsternberg closed 8 years ago

jtsternberg commented 8 years ago

With this implementation, multi-dimensional arrays can be passed to League\OAuth1\Client\Server::getHeaders() and be correctly transformed. For prior art, consider the WP REST API - OAuth 1.0a Server plugin. Specifically:

stevenmaguire commented 8 years ago

There are some code style issues that need to be resolved: https://travis-ci.org/thephpleague/oauth1-client/jobs/108124923

Also, I would like to request to that you provide some test cases that support the changes you are making.

jtsternberg commented 8 years ago

Yes, you're right. Ashamed to admit I didn't read the CONTRIBUTING.md until AFTER submitting.

bencorlett commented 8 years ago

Ditto @stevenmaguire :)

Check out fabpot/php-cs-fixer :)

jtsternberg commented 8 years ago

Closing in favor of #61 which contains tests, and code style issues are addressed.