Allow mult-dimension arrays when generating base string for HMAC-SHA1 signature. Fixes #39

thephpleague / oauth1-client

OAuth 1 Client

MIT License

968 stars 73 forks source link

Allow mult-dimension arrays when generating base string for HMAC-SHA1 signature. Fixes #39 #61

Closed jtsternberg closed 8 years ago

jtsternberg commented 8 years ago

With this implementation, multi-dimensional arrays can be passed to League\OAuth1\Client\Server::getHeaders() and be correctly transformed. For prior art, consider the WP REST API - OAuth 1.0a Server plugin. Specifically:

https://github.com/WP-API/OAuth1/blob/master/lib/class-wp-rest-oauth1.php#L667-L674
https://github.com/WP-API/OAuth1/blob/master/lib/class-wp-rest-oauth1.php#L706-L753

Includes tests. (closing #60)

jtsternberg commented 8 years ago

Related PR against the WP-API/OAuth1 library: https://github.com/WP-API/OAuth1/pull/122

jtsternberg commented 8 years ago

How do you guys feel about this PR? As it is now, multi-dimensional arrays in POSTed data is not possible.

bencorlett commented 8 years ago

After reading through the spec in detail, I can't see why this shouldn't be included!

Thanks :)

jtsternberg commented 8 years ago

👍