Updated dependency in composer.json to use guzzlehttp/guzzle instead of guzzle/guzzle

[pendexgabo]

laravel/socialite and others depending on this package display

Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.

so I've update the guzzle dependency.

Tests seem to run just fine

gabriel@~:oauth1-client (git:master) $ phpunit
PHPUnit 4.8.26 by Sebastian Bergmann and contributors.
Warning:    The Xdebug extension is not loaded
        No code coverage will be generated.

.....................................

Time: 212 ms, Memory: 8.75MB

OK (37 tests, 114 assertions)

[bencorlett]

I'll need to test this - I have a feeling the 1.x tests are mocking a little too much and so we may. D seeing false positives.

I'll update you when I get a chance to either validate there are no false positives, or if there are, fix the tests and the code.

Sent from my iPhone

Please excuse my brevity

On 20 Jul. 2016, at 12:53 am, Gabriel Sosa notifications@github.com wrote:

laravel/socialite and others depending on this package display

Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.

so I've update the guzzle dependency.

Tests seem to run just fine

gabriel@~:oauth1-client (git:master) $ phpunit PHPUnit 4.8.26 by Sebastian Bergmann and contributors. Warning: The Xdebug extension is not loaded No code coverage will be generated.

.....................................

Time: 212 ms, Memory: 8.75MB

OK (37 tests, 114 assertions) You can view, comment on, or merge this pull request online at:

https://github.com/thephpleague/oauth1-client/pull/71

Commit Summary

updated dependency to use guzzlehttp/guzzle instead of guzzle/guzzle File Changes

M composer.json (2) Patch Links:

https://github.com/thephpleague/oauth1-client/pull/71.patch https://github.com/thephpleague/oauth1-client/pull/71.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[pendexgabo]

Thanks.

I can go and check if you can guide me where to look into.

I just want to have a minor or some small release ASAP so we can remove that ugly yellow banner that appears on every composer update ;)

Best regards

On Jul 19, 2016 11:52 PM, "Ben Corlett" notifications@github.com wrote:

I'll need to test this - I have a feeling the 1.x tests are mocking a little too much and so we may. D seeing false positives.

I'll update you when I get a chance to either validate there are no false positives, or if there are, fix the tests and the code.

Sent from my iPhone

Please excuse my brevity

On 20 Jul. 2016, at 12:53 am, Gabriel Sosa notifications@github.com wrote:

laravel/socialite and others depending on this package display

Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.

so I've update the guzzle dependency.

Tests seem to run just fine

gabriel@~:oauth1-client (git:master) $ phpunit PHPUnit 4.8.26 by Sebastian Bergmann and contributors. Warning: The Xdebug extension is not loaded No code coverage will be generated.

.....................................

Time: 212 ms, Memory: 8.75MB

OK (37 tests, 114 assertions) You can view, comment on, or merge this pull request online at:

https://github.com/thephpleague/oauth1-client/pull/71

Commit Summary

updated dependency to use guzzlehttp/guzzle instead of guzzle/guzzle File Changes

M composer.json (2) Patch Links:

https://github.com/thephpleague/oauth1-client/pull/71.patch https://github.com/thephpleague/oauth1-client/pull/71.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thephpleague/oauth1-client/pull/71#issuecomment-233824974, or mute the thread https://github.com/notifications/unsubscribe-auth/AADw6imgQO2FcX6jXG769H1UfgClV0VZks5qXY1RgaJpZM4JP0Bv .

[bencorlett]

The issue here is nearly everybody requires guzzlehttp/guzzle with a constraint up in the ^6 arena. So, we'll need to make it compatible with a newer version to play nicely.

[bencorlett]

See this branch.

I'm still not happy with the amount of mocking we're doing here, but since a V2 release is imminent, I'll test the package myself tomorrow and validate I haven't made some silly error before releasing a patch update to end users.

[bkintanar]

Hi @bencorlett do we have an update on this?

[bencorlett]

No. I did not get time to look at it so I will on Monday

[pendexgabo]

Hi @bencorlett!

Were you able to test? Thank you!

[pendexgabo]

Hey guys,

First of all, I know you are super busy and the whole community really appreciate your hard work. But how can we help in any way so you can release a new tag for this package?

Best Regards

[bencorlett]

Heya Gabriel,

I must apologise for this, I have been super under the pump (getting ready for a holiday), however I am going to set aside some time right now to look at this and get to some sort of resolution. Stand by :)

On 17 Aug 2016, at 3:25 AM, Gabriel Sosa notifications@github.com wrote:

Hey guys,

First of all, I know you are super busy and the whole community really appreciate your hard work. But how can we help in any way so you can release a new tag for this package?

Best Regards

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thephpleague/oauth1-client/pull/71#issuecomment-240174858, or mute the thread https://github.com/notifications/unsubscribe-auth/AALGn_rJNSnpi-Q4QN7ouCD0jp-TbFnUks5qgfKlgaJpZM4JP0Bv.

[j3j5]

FWIW, I've been testing the branch update-v1-to-guzzle-v6 for a few days and it seems to work fine, at least with Twitter.

[bencorlett]

Thank you very much for your help @pendexgabo, I have combined both your code and @guss77's code (from #75) to combine and mega into master. I have released Version 1.7 which supports the latest version of Guzzle.

Enjoy! ✌️

[pendexgabo]

Thank you very much. Enjoy your holidays!