search

thephpleague / oauth1-client

OAuth 1 Client
MIT License
968 stars 73 forks source link

Including non-standard ports into a base string #81

Closed kavw closed 7 years ago

kavw commented 7 years ago

This PR fixes building a signature basic string according to this section https://oauth.net/core/1.0a/#rfc.section.9.1.2

bencorlett commented 7 years ago

Hi there, we are not using OAuth 1.0a, we are using the specification which supersedes it - RFC 5849.

We actually need to include these parameters according to the newer spec.

Thank you for the PR however! I'm sorry this slipped right off my radar.

vfranchi commented 6 years ago

I was getting signature errors because of this. The server I'm using uses a different port and it was not getting into the baseString for signing the request.

Thanks for this fix!