thephpleague / oauth2-client

Easy integration with OAuth 2.0 service providers.
http://oauth2-client.thephpleague.com
MIT License
3.65k stars 751 forks source link

Test against php 8.1 #910

Closed sergiy-petrov closed 2 years ago

jrfnl commented 3 years ago

Please see PR #915 - the build would currently NOT pass on PHP 8.1. This was "invisible" due to incorrect configuration, but that does not mean that the package is compatible with PHP 8.1 without further changes. Please see PRs #919 and #920 for the changes which are needed.

sergiy-petrov commented 3 years ago

Hi @jrfnl Wow I didn't know that error_reporting is default to E_ALL & ~E_DEPRECATED & ~E_STRICT in SetupPHP actions. Thanks for the info.

I think my PR can be merged later, when #915, #919 and #920 are merged in?

jrfnl commented 3 years ago

Hi @jrfnl Wow I didn't know that error_reporting is default to E_ALL & ~E_DEPRECATED & ~E_STRICT in SetupPHP actions. Thanks for the info.

Yes, was an unpleasant discovery when I found that out myself ;-) Resulted in lots of lots of PRs to fix this in the actions workflows of various repos.

I think my PR can be merged later, when #915, #919 and #920 are merged in?

Correct, but those do need to be merged first.

codecov[bot] commented 2 years ago

Codecov Report

Merging #910 (44e0933) into master (3a66916) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #910   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       180       180           
===========================================
  Files             20        20           
  Lines            464       464           
===========================================
  Hits             464       464           
ramsey commented 2 years ago

Thank you!