search

thephpleague / oauth2-client

Easy integration with OAuth 2.0 service providers.
http://oauth2-client.thephpleague.com
MIT License
3.66k stars 753 forks source link

pkce no longer appears in src/Provider/AbstractProvider.php #982

Closed drennvinn closed 1 year ago

drennvinn commented 2 years ago

Hello, I installed the project via composer (2.6.1) and started using it as described here but found out that AbstractProvider.php no longer had support for PKCE when I wanted to use 

$provider = new \League\OAuth2\Client\Provider\GenericProvider([
    // ...
    // other options
    // ...
    'pkceMethod' => \League\OAuth2\Client\Provider\GenericProvider::PKCE_METHOD_S256
]);

So when i navigate to https://github.com/thephpleague/oauth2-client/blob/master/src/Provider/AbstractProvider.php i can found setPkceCode(), getPkceCode(), etc... but not in the sources after composer install

megaxorg commented 1 year ago

Composer installs v2.6.1 from December 2021. PKCE support was added on Sep 12, 2022.

https://github.com/thephpleague/oauth2-client/pull/901

rhertogh commented 1 year ago

@drennvinn As @megaxorg mentioned the latest changes aren't released yet. In the meantime you can use this workaround.

carlituxman commented 1 year ago

Trying the PR 43c59dd it works.

ramsey commented 1 year ago

PKCE support is now available in version 2.7.0.