Closed shadowhand closed 9 years ago
Also, I would not recommend extending GenericResourceOwner
for GithubResourceOwner
as it doesn't offer much of value.
I've addressed these concerns. I did not find the name resourceOwnerId
within the generic class to be intuitive. It no longer matters, this resource owner is no longer extending that class and has implemented the expected behavior correctly now.
The getId method should be returning the actual value, not the key name.