search

thephpleague / oauth2-github

GitHub Provider for the OAuth 2.0 Client
MIT License
106 stars 29 forks source link

Resource owner id is not correct #1

Closed shadowhand closed 9 years ago

shadowhand commented 9 years ago

The getId method should be returning the actual value, not the key name.

shadowhand commented 9 years ago

Also, I would not recommend extending GenericResourceOwner for GithubResourceOwner as it doesn't offer much of value.

stevenmaguire commented 9 years ago

I've addressed these concerns. I did not find the name resourceOwnerId within the generic class to be intuitive. It no longer matters, this resource owner is no longer extending that class and has implemented the expected behavior correctly now.