search

thephpleague / oauth2-github

GitHub Provider for the OAuth 2.0 Client
MIT License
106 stars 29 forks source link

Type error in GithubResourceOwner #17

Closed Seldaek closed 3 years ago

Seldaek commented 3 years ago

This here declares string|null

https://github.com/thephpleague/oauth2-github/blob/master/src/Provider/GithubResourceOwner.php#L38

But calling it returns an int. I'm not sure if the docblock should be fixed or if it should be cast to a string.. But I guess fixing the docblock is the most BC change.

shadowhand commented 3 years ago

Released in version 3.0.0