search

thephpleague / oauth2-github

GitHub Provider for the OAuth 2.0 Client
MIT License
106 stars 29 forks source link

Add a workaround retrieving the resource owner email #20

Closed Gyvastis closed 1 year ago

Gyvastis commented 1 year ago

The resource owner email is always null, as stated in the issue https://github.com/thephpleague/oauth2-github/issues/19.

codecov[bot] commented 1 year ago

Codecov Report

Merging #20 (90fa802) into main (266e958) will not change coverage. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main       #20   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        23        26    +3     
===========================================
  Files              3         3           
  Lines             46        52    +6     
===========================================
+ Hits              46        52    +6
Impacted Files Coverage Δ
src/Provider/Github.php 100.00% <100.00%> (ø)
...ider/Exception/GithubIdentityProviderException.php 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

shadowhand commented 1 year ago

@Gyvastis this looks great. Once tests are added I will merge.

Gyvastis commented 1 year ago

@Gyvastis this looks great. Once tests are added I will merge.

Done shadowhand

shadowhand commented 1 year ago

Released as version 3.1.0.