thephpleague / oauth2-server-bundle

Symfony bundle for the OAuth2 Server.
MIT License
181 stars 88 forks source link

Fix order of converting user #147

Open RobertMe opened 1 year ago

RobertMe commented 1 year ago

Only convert the user from Symfony to League when no response is set on the event. As conversion doesn't / shouldn't have any side effects and the AuthorizationRequest isn't stored either (when a response is set) this should be safe. This helps in those cases where no user is logged in / resolved, but one of the listeners sets a redirect. Otherwise the converter will be called with a null value and has to return a proper value (can't be null) for no obvious reason except to satisfy the interface.