search

thephpleague / oauth2-server-bundle

Symfony bundle for the OAuth2 Server.
MIT License
176 stars 86 forks source link

Improve NullUser with implementation of UserEntityInterface #152

Closed AurelienPillevesse closed 10 months ago

AurelienPillevesse commented 11 months ago

Add implementation of UserEntityInterface for NullUser to be aligned with OAuth2-Server library

chalasr commented 11 months ago

Could you please provide some link pointing to the related change on league/oauth2-server?

AurelienPillevesse commented 11 months ago

There is no update from league/oauth2-server but this class implements everything except this little update

X-Coder264 commented 10 months ago

The NullUser is supposed to be used only in the context of the Symfony security layer (as that's what it was added for in the first place - in order to be able to use the client credentials grant in Symfony apps as that grant does not have a real user associated with it). I'm not sure what exactly do you want to achieve by making it implement an unrelated non Symfony interface?

chalasr commented 10 months ago

As @X-Coder264 said, this is not desired as we have entities separated from security objects. Thanks for proposing.