search

thephpleague / oauth2-server

A spec compliant, secure by default PHP OAuth 2.0 Server
https://oauth2.thephpleague.com
MIT License
6.52k stars 1.12k forks source link

Change query delimiter sign to question mark #1219

Closed alirezadp10 closed 3 years ago

alirezadp10 commented 3 years ago

Hey there! I've testing implicit grant type and find out maybe query delimiter default value is wrong. so when I tried to get token in query string I came across this this URL:

http://localhost:5000/third-party#access_token=eyJ0...&state=u4J2...

which is not accessible from Illuminate\Support\Facades\Http\Request object. so I think if query delimiter default value is changed, every thing will be fine

http://localhost:5000/third-party?access_token=eyJ0...&state=u4J2...
Sephster commented 3 years ago

The default in the spec is to have this as a #. If you need to change it for your own purposes, please use the constructor. Many thanks.