thephpleague / oauth2-server

A spec compliant, secure by default PHP OAuth 2.0 Server
https://oauth2.thephpleague.com
MIT License
6.51k stars 1.12k forks source link

I got this issue when upgrade to 8.3.0 "The request is missing a required parameter, includes an invalid parameter value, includes a parameter more than once, or is otherwise malformed" #1232

Closed hungcrush closed 3 years ago

hungcrush commented 3 years ago

Hi, Please help me how to fix this issue:

"The request is missing a required parameter, includes an invalid parameter value, includes a parameter more than once, or is otherwise malformed"

When I downgrade to 8.2.4 it works well..

I'm using Laravel Passport

Sorry for my english not well.. Thank you

exception0x876 commented 3 years ago

It breaks because of the changed condition here

src/Grant/AbstractGrant.php line 241 if (\is_string($clientId))

Laravel Passport uses integers for $clientId

Previously the condition was checking is_null so it worked just fine.

hungcrush commented 3 years ago

It breaks because of the changed condition here

src/Grant/AbstractGrant.php line 241 if (\is_string($clientId))

Laravel Passport uses integers for $clientId

Previously the condition was checking is_null so it worked just fine.

Thank you so much. I got it

Sephster commented 3 years ago

Reverted the offending check 👍