search

thephpleague / oauth2-server

A spec compliant, secure by default PHP OAuth 2.0 Server
https://oauth2.thephpleague.com
MIT License
6.51k stars 1.12k forks source link

Bug: GrantTypeInterface not respected #1257

Closed tobias-trozowski closed 2 years ago

tobias-trozowski commented 2 years ago

when enabling a grant type via enableGrantType the provided type GrantTypeInterface is not respected ($grantType->revokeRefreshTokens($this->revokeRefreshTokens);). A non-existent method will be called.

I just added unit test to test against a custom grant type

Sephster commented 2 years ago

I think this is related to the changes in PR #1189. If I am understanding correctly, an update to the interface to add the revokeRefreshTokens method in the next major release should fix this. Can you confirm this is what you are expecting @tobias-trozowski?

It threw me a little that your PR isn't addressing this specific issue (but thank you all the same for submitting this).

tobias-trozowski commented 2 years ago

@Sephster i wouldn't say "expect" but adding the method would do just fine. Thank you so much!

Sephster commented 2 years ago

Thanks @tobias-trozowski - the interface change will be added to the next major release. Thank you for the PR too