search

thephpleague / oauth2-server

A spec compliant, secure by default PHP OAuth 2.0 Server
https://oauth2.thephpleague.com
MIT License
6.53k stars 1.12k forks source link

Use league/uri for true URI validation #1274

Closed bradjones1 closed 2 years ago

bradjones1 commented 2 years ago

Fixes https://github.com/thephpleague/oauth2-server/issues/1273

bradjones1 commented 2 years ago

I think this is a bit more elegant than https://github.com/thephpleague/oauth2-server/pull/1237 - though that does include some test coverage for URIs, so we should include that here too.

Speaking of tests, it doesn't appear the failures on this PR seem to be related to my changes... but I'll have to dig deeper.

bradjones1 commented 2 years ago

Tests are failing wth

Error: Call to undefined method LeagueTests\Stubs\GrantType::revokeRefreshTokens()

Doesn't feel related to this change but the test setup.

Sephster commented 2 years ago

No this is an ongoing issue I've not bothered to resolve as will be fixed in the next major. Happy to ignore it. Sorry for any confusion there

Sephster commented 2 years ago

Thanks @bradjones1 - this looks great and I'm embarrassed to say it didn't occur to me to use this library. Great find and thanks for the PR