search

thephpleague / oauth2-server

A spec compliant, secure by default PHP OAuth 2.0 Server
https://oauth2.thephpleague.com
MIT License
6.49k stars 1.12k forks source link

Offering of help with maintenance #1332

Closed GrahamCampbell closed 1 year ago

GrahamCampbell commented 1 year ago

I noticed that the tests are failing, and this package is not installable on PHP 7.2 due to incorrect dependences, and is not tested on PHP 8.1 or 8.2. I was wondering if you needed some help with the maintenance of this package. I maintain and co-maintain lots of packages, including Guzzle and Laravel, and (not that it has had much love recently) league/factory-muffin-faker. I am happy help out here in whatever ways you need, including pairing if that's what's needed to fix up things here.

Sephster commented 1 year ago

Thanks Graham. That's very kind to offer but I should be ok. I welcomed a son at the start of the year so things have been a bit hectic for a while but I've started work on upgrading tests now and getting things in order. Should have an update out in the next few days.

Thank you for the kind offer though. It is appreciated 👍

GrahamCampbell commented 1 year ago

Congratulations. The offer still stands, in any case, including if you want any code review. 🚀

GrahamCampbell commented 1 year ago

FYI, the original thing that drove me here was incompatibility with lcobucci/jwt v5 (and actually later version of v4 - arguably breaking changes were introduced into the v4 series as bug fixes that break things for this library, or at least they do when executed through Laravel Passport). I stopped after seeing that we didn't have a way to test the package would work since it requires PHP 8.1, and we don't have a working test suite yet for PHP 8.1. I'm happy to re-visit this once we have CI going and passing tests as a baseline.