thephpleague / oauth2-server

A spec compliant, secure by default PHP OAuth 2.0 Server
https://oauth2.thephpleague.com
MIT License
6.52k stars 1.12k forks source link

Bump laminas-diactoros, psr/http-message versions #1339

Closed erikn69 closed 1 year ago

erikn69 commented 1 year ago

Updates the requirements on laminas/laminas-diactoros to allow the latest version.

3.0.0 Release Notes for 3.0.0 Added This version adds support for PSR-7 v2.0. While we had previously added return type hints in Diactoros, there were a few cases where PSR-7 updated the interfaces to use void returns where we had not. As a result, this release represents a BC break for anybody extending our classes, as defining an extension that uses one of these methods with a mixed return type (or omitting the return type entirely) will result in a type error.

The interfaces affected were Psr\Http\Message\StreamInterface and Psr\Http\Message\UploadedFileInterface.

For consumers, this version should be entirely backwards compatible in usage. For those extending our classes, you will only run into issues when extending implementations of the above interfaces.

Sephster commented 1 year ago

Thanks for the PR @erikn69 - just some minor comments from me

driesvints commented 1 year ago

@Sephster can we maybe release this as a patch release? We're getting so much issues on Passport about this 😅

Sephster commented 1 year ago

Damn I thought I had sorry @driesvints . Will release tonight

driesvints commented 1 year ago

Thanks!