search

thephpleague / oauth2-server

A spec compliant, secure by default PHP OAuth 2.0 Server
https://oauth2.thephpleague.com
MIT License
6.49k stars 1.12k forks source link

Fix inconsistent var #1352

Closed AurelienPillevesse closed 1 year ago

AurelienPillevesse commented 1 year ago

Fix inconsistent @var based on @param and @return in the same class

Sephster commented 1 year ago

I think this is never not a string from memory. Folks might set it as a numeric value but I think because it is sent over http it is always a string. Have I made a mistake here? Closing for now but if I am not correct please shout and I will take a second look. Thank you

AurelienPillevesse commented 1 year ago

@Sephster I don't have everything you have in mind but in my point of view, the setter and getter are mixed so the var have to be mixed too. Currently, when I use this Trait, it has to be a string