search

thephpleague / oauth2-server

A spec compliant, secure by default PHP OAuth 2.0 Server
https://oauth2.thephpleague.com
MIT License
6.49k stars 1.12k forks source link

Test Refresh Token Fails on Google Home Test Suite #1379

Closed w1lldone closed 8 months ago

w1lldone commented 8 months ago

Hello everyone, i've been using oauth2-server, along with Laravel Passport to build an integration for Google Home Cloud to Cloud. We have encountered a test failure within the Google Home Test Suite:

image

Error happened during refresh with invalid token. This is likely because partner didn't return invalid_grant with 400. Please check Cloud log if this provider has been associated with cloud project id.;Refresh token has been rotated. This is not forbidden, however we do not see much benefit that rotating the refresh token can provide but the potential problem it has. We also tried to refresh token with the old refresh token after it has been rotated. Refresh didn't work, this means partner invalidated the old refresh token right after the rotation. Partners shall only invalidate the old refresh token after seeing we use the new one to ensure we got it successfully.;: expected 'FAIL' to not equal 'FAIL'

Is anyone else experiencing this issue?

eugene-borovov commented 8 months ago

Try to not revoke refresh token.

Sephster commented 8 months ago

Aye, try to turn off the revoking of refresh tokens. This can be done in the AuthorizationServer class. There is a public function called revokeRefreshTokens. Thanks @eugene-borovov