search

thephpleague / oauth2-server

A spec compliant, secure by default PHP OAuth 2.0 Server
https://oauth2.thephpleague.com
MIT License
6.49k stars 1.12k forks source link

Fix including interval in response of device authorization request #1410

Open hafezdivandari opened 1 month ago

hafezdivandari commented 1 month ago

I'm implementing device authorization flow on Laravel Passport, but when I call $grant->setIntervalVisibility(true) the response still doesn't include interval. On the response you are excluding interval when it's set to default 5. Although the server may use the default interval value, we still want to include the internal on the response.

PS: Also a typo has been fixed on DeviceCodeRepositoryInterface, $deviceCodeEntity -> $deviceCode

Sephster commented 3 days ago

@hafezdivandari apologies I've not forgotten about this. My partner is sick just now and my son has a sickness bug so I have little time but will get to it as soon as she is better. Apologies for the delay. Just wanted to give you an update

hafezdivandari commented 3 days ago

@Sephster No worries at all! Take all the time you need. I hope your family feels better soon.