judgej
commented
6 years ago It is actually the version of PHPUnit (3.9) that is failing on the deprecated each statement in PHP 7.2 (I think phpcs is picking up on that). Otherwise, the code certainly passes the PHPUnit tests locally under PHP 7.2 We are probably going to be stuck with that version for OmiPay 2.x
Too many unknowns in here to go live soon though.
The method converting the XML object to an array was failing on PHP 7.2 I really could not see why this was happening.
The conversion method was swapped to one that uses JSON as an intermediate step. This seems to work, and does not generate the additional single-element arrays between nested level. I'm slightly concerned those extra levels were needed, but not utterly convinced. I'll run a few checks to see what the impact could be.