search

thephpleague / omnipay-braintree

Braintree Driver for Omnipay Gateway
MIT License
34 stars 50 forks source link

Fix missing config values in webhook testing #50

Open dennislindsey opened 4 years ago

dennislindsey commented 4 years ago

Resolves #37

dennislindsey commented 4 years ago

Tests are failing for PHP 5.6 and 7.0 because phpunit no longer supports them as they've both reached end-of-life.

barryvdh commented 4 years ago

Why did you add void return types? They are not supported in older PHP versions.

dennislindsey commented 4 years ago

I mistakenly ran the tests to confirm the change using my globally-installed version of phpunit rather than the one that ships with the project. The tests were failing because of the missing return types since phpunit no longer supports PHP versions 5.6 and 7.0. I removed the return types and re-ran the tests using the provided version of phpunit.