Buckaroo All gateway

[yasasn86]

buckaroo payments methods select page

[silvano-a]

Is this pull request complete? what does it do?

[yasasn86]

It helps to go to buckaroo payments methods select page, so that we can select any payment method supported by buckaroo there. we can use the gateway Buckaroo_All to do that if you merged this code. I don't know whether there is another way to do that currently.

[silvano-a]

there is, yes :)

it's called the 'PurchaseRequest'.

usage: $gateway = new BuckarooGateway(); $gateway->purchase();

[yasasn86]

ok. I was using omnipay with payum bundle. here is my current configuration buckaroo_via_omnipay:     factory: omnipay     type: Buckaroo_All     websiteKey: %buckaroo_website_key%     secretKey: %buckaroo_secret_key%     testMode: %test_mode%

I don't know which name should be used for type in this configuration as you suggest. If I use Buckaroo it does not work and throws an error. but if I use Buckaroo_All it works well (with the code in this pull request) .

here is a screenshot for the error I get when I use Buckaroo as the gateway.

[silvano-a]

Could you try replacing type: Buckaroo_All by type: Buckaroo_Buckaroo and post the results here? https://github.com/thephpleague/omnipay-buckaroo/issues/22

[yasasn86]

type: BuckarooGateway

[yasasn86]

ok. my first sreenshot is for type: Buckaroo https://cloud.githubusercontent.com/assets/3061748/18831647/7516c214-8404-11e6-8237-22e8e1bc6d77.png

[silvano-a]

i've created an issue for this. it seems that there is something going wrong in the 'BuckarooGateway' lets move the discussion over there https://github.com/thephpleague/omnipay-buckaroo/issues/22

[yasasn86]

ok. I think if we change the class name of BuckarooGateway to Gateway, it will fix the issue class BuckarooGateway extends AbstractGateway { public function getName() { return 'Buckaroo Gateway'; } ... to class Gateway extends AbstractGateway { public function getName() { return 'Buckaroo'; } ...

as in the omnipay-worldpay https://github.com/thephpleague/omnipay-worldpay/blob/master/src/Gateway.php

[silvano-a]

can you confirm if this works, and if so, create a pull request including unit test?

[yasasn86]

I just checked it and it worked with class name Gateway

class Gateway extends AbstractGateway { public function getName() { return 'Buckaroo'; } ....

[silvano-a]

nice!

Could you create a pull request that fixes this?

[yasasn86]

ok. I will create a pull request :)

[silvano-a]

awesome! then this PR can be closed as an issue is opened for it, and this PR is not the solution to the problem