thephpleague / omnipay-buckaroo

Buckaroo driver for the Omnipay PHP payment processing library
MIT License
13 stars 30 forks source link

fix `Buckaroo Gateway` does not appear as supported when choosing a type #23

Closed yasasn86 closed 8 years ago

yasasn86 commented 8 years ago

fixes #22

delatbabel commented 8 years ago

OK I am happy to merge this but it breaks BC. So for example users who previously called Omnipay::create('Buckaroo_Buckaroo'); will now just call Omnipay::create('Buckaroo'); So it will have to be a minor version change at least with a release note.

I will leave it a few days to see if the core team have any other comments.

yasasn86 commented 8 years ago

ok. Now, there is no need to merge this PR. Buckaroo_Buckaroo solves my issue in #21 conversation. I didn't know which name should be used. thanks delatbabel :)