Make Brq_signature data key case-insensitive.

thephpleague / omnipay-buckaroo

Buckaroo driver for the Omnipay PHP payment processing library

MIT License

13 stars 30 forks source link

Make Brq_signature data key case-insensitive. #4

Closed rjkip closed 10 years ago

rjkip commented 10 years ago

The key was included in signature calculation and comparison when its case was different than 'Brq_signature' as described in omnipay/buckaroo#3.

The tests do pass, but fail on Travis due to omnipay/tests#1.

rjkip commented 10 years ago

Please wait, more key case-sensitivity present.

amacneil commented 10 years ago

Thanks, it looks good. I fixed the issue with Mockery 0.9. Can you rebase and squash your changes?

rjkip commented 10 years ago

Will do later today.

rjkip commented 10 years ago

@adrianmacneil Done. Thanks for your effort in the Omnipay libraries.

amacneil commented 10 years ago

Thanks for your contribution :) I just made a couple of slight edits to avoid a PHP warning if brq_signature was missing from $_GET, and kept the uppercase logic in the CompletePurchaseRequest. Can you test it and make sure everything still works as expected?

rjkip commented 10 years ago

Ah, sloppy. Should work, will run through it on Monday.

rjkip commented 10 years ago

@adrianmacneil All works as expected.