Test gateways against omnipay

thephpleague / omnipay-common

Core components for the Omnipay PHP payment processing library

MIT License

329 stars 243 forks source link

Test gateways against omnipay #109

Open barryvdh opened 8 years ago

barryvdh commented 8 years ago

We should enfore better testing with Omnipay Common. 1 thing we can do is test both dev, stable en lowest versions, like this: https://github.com/thephpleague/omnipay-paypal/pull/137

Second thing is that we might want to trigger the testcase for all gateways somehow. Not sure if that is even possible? Preferably before a PR is merged, but that would mean pulling down all gateways and running all tests.. Any ideas?

delatbabel commented 8 years ago

In the case of an individual gateway, I normally ask the submitter of a PR to test this in production before I tag for release. I'm not sure what else we can do -- these issues fail due to a combination of:

The tests pass, but the code fails due to gateway issues
Some gateways don't always make it easy to get hold of test accounts.
Some gateways behave differently between test and production accounts.

barryvdh commented 8 years ago

Yes but I mean specifically for omnipay common, as that is used across all gateways. A breaking change here can affect a gateway we are not aware of. So after each change, all the gateway tests should be triggered also.

delatbabel commented 8 years ago

If you're asking for wave-a-magic-wand fixes to make that happen, sorry but I don't have any. :) I guess we just have to be careful with changes to omnipay-common. It was good that this got caught on the dev branch before it got tagged for release though.