thephpleague / omnipay-common

Core components for the Omnipay PHP payment processing library
MIT License
330 stars 244 forks source link

New currencies added #136

Closed dercoder closed 7 years ago

barryvdh commented 7 years ago

Where did you get these from?

dercoder commented 7 years ago

I got them from https://github.com/Payum/iso4217/blob/master/ISO4217.php#L109 and his source is: https://en.wikipedia.org/wiki/ISO_4217

dercoder commented 7 years ago

Can you also create a new release?

judgej commented 7 years ago

Thought about going direct to the source of sources?

http://www.currency-iso.org/dam/downloads/lists/list_one.xml

There is a command-line tool here for mapping that feed onto multiple other formats to semi-automate keeping it up to date:

https://github.com/moneyphp/iso-currencies/blob/master/bin/fetch-update.php

dercoder commented 7 years ago

This is a good idea but Bitcoins are missing in this list

judgej commented 7 years ago

Are there gateways that accept BTC as a currency? Genuinely curious, since it's not an ISO currency.

dercoder commented 7 years ago

Maybe https://github.com/thephpleague/omnipay-coinbase

barryvdh commented 7 years ago

In v3 we're using this list directly: https://github.com/alcohol/iso4217

judgej commented 7 years ago

Nice. Not duplicating these lists all over the place is, of course, the right way to go. I'm nabbing that for another project too :-)