Direct CardType should be UPPER CASE

judgej commented 7 years ago

The Sage Pay documentation for the Direct CardType field states:

The value should be in UPPERCASE.

With examples such as VISA, MC and MCDEBIT. The CardType in this driver gets its values from OmniPay, which is always lower case. Several things to consider:

Sage Pay seems to accept lower case, but this should be fixed in case the documentation is strictly enforced one day.
I have not checked the permitted card type values for other Sage Pay gateways. They may not all require upper case strings.
The total list of supported card strings that Sage Pay lists should be checked against the list that OmniPay holds. There may be some additional mapping that is needed.

Docs (August 2015, may be more now):

VISA is Visa
MC is MasterCard
MCDEBIT is Debit MasterCard
DELTA is Visa Debit
MAESTRO is Domestic and International issued
Maestro
UKE is Visa Electron
AMEX is American Express
DC is Diners Club International and Discover
JCB is Japan Credit Bureau
LASER is Laser (withdrawn as of 28th February 2014)
PAYPAL

judgej commented 7 years ago

Does the Sage Pay Direct driver attempt to auto-detect the card type if not supplied explicitly? I'm not sure it does, but it should (to check).

judgej commented 7 years ago

Agh! Bugger. I was posting this to the Sage Pay driver, or so I thought.

judgej commented 7 years ago

Moved to https://github.com/thephpleague/omnipay-sagepay/issues/84

thephpleague / omnipay-common

Direct CardType should be UPPER CASE #141